Skip to content

feat(pascal): create exercise #447

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat(pascal): create exercise #447

wants to merge 14 commits into from

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Mar 24, 2024 •
edited
Loading

Because

It was decided to add new recursion exercises

This PR

  • Adds exercise 19

Issue

Related to #27265

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the /solutions folder

@nik-rev nik-rev marked this pull request as draft March 24, 2024 16:21
@nik-rev nik-rev changed the title New exercise | Pascal (19) New exercise | Pascal Mar 24, 2024
@nik-rev nik-rev mentioned this pull request Mar 24, 2024
Open
3 tasks
@nik-rev nik-rev marked this pull request as ready for review May 3, 2024 00:09
@nik-rev
Copy link
Contributor Author

nik-rev commented May 3, 2024

Ready for review now!!

MaoShizhong
MaoShizhong suggested changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

nik-rev and others added 2 commits June 29, 2024 18:06
@nik-rev @MaoShizhong
refactor: make code more readable
26f5679 
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@nik-rev @MaoShizhong
refactor: remove unnecessary line break
c629198 
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@nik-rev nik-rev changed the title (19) New exercise | Pascal feat(pascal): create exercise Aug 9, 2024
MaoShizhong
MaoShizhong suggested changes Aug 18, 2024
View reviewed changes
nik-rev and others added 2 commits August 18, 2024 16:27
@nik-rev
feat(pascal): better names for variables
b5adfce
@nik-rev @MaoShizhong
feat(pascal): math mistake
ca43c00 
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@nik-rev nik-rev requested a review from MaoShizhong August 18, 2024 17:34
MaoShizhong
MaoShizhong reviewed Aug 20, 2024
View reviewed changes
@MaoShizhong MaoShizhong added the Status: Do Not Merge This PR should not be merged until further notice label Aug 20, 2024
nik-rev and others added 2 commits August 20, 2024 23:38
@nik-rev @MaoShizhong
fix(pascal): typo
d64601a 
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@nik-rev
feat(pascal): copy over tests from solution
ad37314
MaoShizhong
MaoShizhong reviewed Aug 25, 2024
View reviewed changes
nik-rev and others added 2 commits August 25, 2024 16:59
@nik-rev @MaoShizhong
feat: remove line break
f9bbd25 
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@nik-rev @MaoShizhong
feat: remove line break
fc4bd94 
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
JoshDevHub
JoshDevHub reviewed Feb 15, 2025
View reviewed changes
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JoshDevHub JoshDevHub JoshDevHub left review comments

@MaoShizhong MaoShizhong MaoShizhong approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Do Not Merge This PR should not be merged until further notice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik-rev @JoshDevHub @MaoShizhong